Repository navigation
log: the 3D camera is the shadow LOD origin, and bevy_time's warning is filtered - #104
Merged
Merged
Conversation
…warning filtered Every 3D run with a point or spot light warned that no entity has ShadowLodOrigin (the scene camera draws into an image, so Bevy picked one arbitrarily): the scene camera now carries the marker. bevy_time's "did not receive the time from the render world" (raea drives Time by frame, with the render world in step) is filtered out of stderr, in Bevy's log filter and in raea_io_trace's logger; the event log keeps every record. Measured on main 5b2c773: a 3D still with a point light printed the ShadowLodOrigin warning, now nothing; a 2D still printed bevy_time's line, now not. The 54 dropped bevy_ecs CommandQueue lines on a 2D still are left as they are: their source still needs finding. Part of shinyobjectz#89 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The two new comments said in five lines what fits in three; raea-render was 2 lines over tools/size.sh's 2,000-line crate limit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
shinyobjectz
added a commit
that referenced
this pull request
Nov 12, 2026
…ash, so the check has room for #89's fixes apps/check was at its 2,000-line limit (tools/size.sh) with three of #89's items still to come. The screen itself (Px, Swings, FlashScreen: WCAG 2.3.1's opposing swings in a frame's windows, from decoded RGB) is pure pixel maths with nothing of the check's, so it moves to apps/check/flash with its six tests, unchanged; the FFmpeg side (the decode, showinfo's exact times, the log's severities, the findings) stays in flash.rs. apps/check goes to 1,680 lines. CI's unit tests take the new crate too. And raea-render's log-filter comment is folded a line shorter: the merge of #104 left the crate at 2,001.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Mattias
Part of #89 (item 7). This includes only the marker and the filter, as you asked; the 54 dropped CommandQueue lines are left to you.
What changes
ShadowLodOrigin(engine/render/src/engine/spawn.rs). Every 3D run with a point or spot light warned that no entity had it.raea_io_trace's logger. raea drives Time by frame with the render world in step. The event log keeps every record.Measured on main 5b2c773
Also merged onto main 0ea4eab together with the other open PRs from this review: their crates' tests pass (118, 0 failed).
🤖 Generated with Claude Code